Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backport): Improve warnings for qmu and qmu_tilde for the set POI bounds #2426

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

matthewfeickert
Copy link
Member

Description

Please describe the purpose of this pull request in some detail. Reference and link to any relevant issues or pull requests.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Backport PR https://github.com/scikit-hep/pyhf/pull/2390
* Add Lorenz Gaertner to contributors list.

…I bounds

* Add information to the user in the warning that provides them with the
  higher level pyhf.infer APIs kwarg to set the correct test statistic.
@matthewfeickert matthewfeickert added feat/enhancement New feature or request docs Documentation related backport Backport PRs from main to release branch labels Jan 5, 2024
@matthewfeickert matthewfeickert self-assigned this Jan 5, 2024
@matthewfeickert matthewfeickert merged commit 0f440e8 into release/v0.7.x Jan 5, 2024
14 of 15 checks passed
@matthewfeickert matthewfeickert deleted the backport/warning-improvement branch January 5, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport PRs from main to release branch docs Documentation related feat/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants